Move app name setting to new nested settings object#16762
Merged
Conversation
cicdw
requested review from
desertaxle,
discdiver and
zzstoatzz
as code owners
CodSpeed Performance ReportMerging #16762 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the new and unreleased
app_namefield I added recently to a dedicated new section of settings for connect args. I didn't want to add more logic yet as I want to be mindful of changes to settings, but ultimately I think this is the place to put the new fields suggested in #16374 and there are a few top-level settings within[database]that could be deprecated and moved here (connection_timeoutandtimeoutfor example).